Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Highlighted Text Cannot Be Printed #2604

Merged
merged 3 commits into from
May 5, 2024
Merged

BUG: Highlighted Text Cannot Be Printed #2604

merged 3 commits into from
May 5, 2024

Conversation

Nifury
Copy link
Contributor

@Nifury Nifury commented Apr 19, 2024

Currently, pypdf does not set annotation flags when highlighting text. The flag at bit 3 needs to be set in order to print highlighted text.
image

@Nifury Nifury changed the title Add print flag for highlight BUG: Highlighted Text Cannot Be Printed Apr 19, 2024
@stefan6419846
Copy link
Collaborator

Thanks for the PR. Shouldn't we make this optional to let the user decide whether printing should be enabled or not and add some test accordingly?

@stefan6419846 stefan6419846 added the workflow-annotation Everything about annotating PDF files label Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (e92b20e) to head (a5f4dfd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2604   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          50       50           
  Lines        8319     8322    +3     
  Branches     1668     1669    +1     
=======================================
+ Hits         7900     7903    +3     
  Misses        260      260           
  Partials      159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846 stefan6419846 added needs-test A test should be added before this PR is merged. needs-change The PR/issue cannot be handled as issue and needs to be improved labels Apr 28, 2024
Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@stefan6419846 stefan6419846 merged commit bcc8214 into py-pdf:main May 5, 2024
16 checks passed
stefan6419846 added a commit that referenced this pull request Jun 23, 2024
## What's new

### New Features (ENH)
- Accept ETen-B5 and UniCNS-UTF16 encodings (#2721) by @pubpub-zz
- Add decode_as_image() to ContentStreams (#2615) by @pubpub-zz
- context manager for PdfReader (#2666) by @tibor-reiss
- Add capability to set font and size in fields (#2636) by @pubpub-zz
- Allow to pass input file without named argument (#2576) by @pubpub-zz

### Bug Fixes (BUG)
- Fix deprecation for Ressources when using old constants (#2705) by @stefan6419846
- Fix images issue 4 bits encoding and LUT starting with UTF16_BOM (#2675) by @pubpub-zz
- Reading large compressed images takes huge time to process (#2644) by @snanda85
- Highlighted Text Cannot Be Printed (#2604) by @Nifury
- Fix UnboundLocalError on malformed pdf (#2619) by @farjasju

### Documentation (DOC)
- Various improvements on docstrings and examples by @j-t-1

### Robustness (ROB)
- Cope with missing Standard 14 fonts in fields (#2677) by @pubpub-zz
- Improve inline image extraction (#2622) by @pubpub-zz
- Cope with loops in Fields tree (#2656) by @pubpub-zz
- Discard /I in choice fields for compatibility with Acrobat (#2614) by @pubpub-zz
- Cope with some issues in pillow (#2595) by @pubpub-zz
- Cope with some image extraction issues (#2591) by @pubpub-zz

### Maintenance (MAINT)
- Deprecate interiour_color with replacement interior_color (#2706) by @j-t-1
- Add deprecate_with_replacement to PdfWriter.find_bookmark (#2674) by @j-t-1

### Code Style (STY)
- Change Link to be a non-markup annotation (#2714) by @j-t-1

[Full Changelog](4.2.0...4.3.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-change The PR/issue cannot be handled as issue and needs to be improved needs-test A test should be added before this PR is merged. workflow-annotation Everything about annotating PDF files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants